Dec 3, 2019
seen from India
seen from India
seen from United States
seen from United States
seen from India
seen from China
seen from Taiwan
seen from China
seen from Singapore
seen from United States
seen from United States
seen from Mexico
seen from United States
seen from Malaysia
seen from China
seen from United States
seen from United Kingdom
seen from Netherlands
seen from Netherlands
seen from United States
How to: Preferred Github workflow for updating a pull request after code review
How to: Preferred Github workflow for updating a pull request after code review
Preferred Github workflow for updating a pull request after code review
I’ve submitted a change to an Open Source project on Github, and received code review comments from one of the core team members (github code review is awesome by the way!). Most of the code is OK but a few things need changing.
Anyway, I would like to update the code taking into account the review comments, and re-submit…
View On WordPress
Fixed How do you attach a new pull request to an existing issue on github? #dev #it #asnwer
Fixed How do you attach a new pull request to an existing issue on github? #dev #it #asnwer
How do you attach a new pull request to an existing issue on github?
I’m not sure, but I have a vague memory of creating a github pull request with “Issue 4″ or something in the title, and it automatically attached itself to Issue 4 in the project that I was submitting it to. I tried it again recently and it didn’t work it just created a brand new issue instead. I don’t see any options like…
View On WordPress
How to: Send a pull request on GitHub for only latest commit
How to: Send a pull request on GitHub for only latest commit
Send a pull request on GitHub for only latest commit
I forked a project on github and am successfully making changes to my local master and pushing to origin on github. I want to send a pull request, but only want to include the last commit. The pull request UI on github.com shows the last 9 commits and I don’t know how to filter that down.
I was trying to understand if I should create a new…
View On WordPress
How to: How do you attach a new pull request to an existing issue on github?
How to: How do you attach a new pull request to an existing issue on github?
How do you attach a new pull request to an existing issue on github?
I’m not sure, but I have a vague memory of creating a github pull request with “Issue 4″ or something in the title, and it automatically attached itself to Issue 4 in the project that I was submitting it to. I tried it again recently and it didn’t work it just created a brand new issue instead. I don’t see any options like…
View On WordPress
An Update to jQSlickWrap
Earlier today, @AlmogBaku submitted the first ever pull request to the github project for jQSlickWrap. He added the ability to have the image rendered as the background-image of the parent div by its src parameter, as opposed to using a data-URI. I think this approach may be better than the data-URI mechanism I was using before, so maybe it'll become the default in the future.
Additionally, while testing the pull request I realized that there was a bug with how the height of parent divs was being set (to make sure the entire image showed.) If you were to resize the window after jQSlickWrap did its business a couple of things could happen: the image could get chopped-off, or the text could overflow the containing div. This behavior has been corrected.
Thanks to these changes, I've upped the version number of jQSlickWrap to 0.2. You can read more about the project and download it from the jQSlickWrap home page. These are the first substantial changes to the code since it was released in 2009!
It really is something special to receive a pull request from a total stranger on a project you created.