#pull request

[jimberrydev]

I just did my first pull request

Wish me luck 🤞

[mrbaguvix]

No! Your feelings should not be hurt by code reviews.

When people make honest reviews to your PR and you get annoyed, then you are not ready to learn.

You either ignore it or reply reluctantly why? (because you’ve written “the perfect code”?). why feel hurt when you can learn?

Bottom line is if you feel hurt or can't put aside your ego then you shouldn't be on a team or contribute to Open Source Community.

Sure! you may explain clearly to the reviewer (maybe s/he didn’t quite get your approach) but do so without being egoistical about it.

[nikoverbeke]

[public-void-main]

This is my face after creating a pull request for the branch I've been working on for the last month. Today I worked 13 hours and the PR was created at 03.47.

I am tired, I need to shower and my eyes hurt, but today was a good day, today I did my best.

[saleck2]

[guangyaw]

在GitHub上利用Fork參與專案開發

GitHub  擁有著龐大的開源程式碼,

上頭有著各式各樣的專案,

當今天對某個專案有興趣,

並且想參與開發,

透過Fork這個功能就能

  在GitHub上利用Fork參與專案開發

  參與開發的流程如下:

  1.   Fork一個專案, 系統會將此專案複製一份到使用者個人的GitHub上

2. 下載自己GitHub上的專案程式碼到本機上編輯,

3.  建立自己的分支後, 開始加入自己的程式碼

4.完成後將此分支上傳至自己的GitHub上

5.提交一個Pull Request給作者

6.由作者決定是否要將此修改Merge到專案中

        在GitHub找到有興趣的專案並fork一份

  接著透過Pycharm下載到本機電腦

下載完畢後開啟專案,

並到  VCS   工具列找到Git,

切換到要執行的分支

第一次進入,

選擇 Remote Branches,

Chec…

View On WordPress

[screwdriver-cd]

Meta PR Comments

Screwdriver now supports commenting on pull requests through Screwdriver build meta. This feature allows users to add custom data such as coverage results to the Git pull request.

Screwdriver Users

To add a comment to a pull request build, Screwdriver users can configure their screwdriver.yaml with steps as shown below:

jobs: main: steps: - postdeploy: | meta set meta.summary.coverage "Coverage increased by 15%" meta set meta.summary.markdown "this markdown comment is **bold** and *italic*"

These commands will result in a comment in Git that will look something like:

Cluster Admins

In order to enable meta PR comments, you’ll need to create a bot user in Git with a personal access token with the public_repo scope. In Github, create a new user. Follow instructions to create a personal access token, set the scope as public_repo. Copy this token and set it as commentUserToken in your scms settings in your API config yaml.

You need this headless user for commenting since Github requires public_repo scope in order to comment on pull requests (https://github.community/t5/How-to-use-Git-and-GitHub/Why-does-GitHub-API-require-admin-rights-to-leave-a-comment-on-a/td-p/357). For more information about Github scope, see https://developer.github.com/apps/building-oauth-apps/understanding-scopes-for-oauth-apps.

Compatibility List

In order to use the new meta PR comments feature, you will need these minimum versions:

API:v0.5.545

Contributors

Thanks to the following people for making this feature possible:

tkyi

Screwdriver is an open-source build automation platform designed for Continuous Delivery. It is built (and used) by Yahoo. Don’t hesitate to reach out if you have questions or would like to contribute: http://docs.screwdriver.cd/about/support.

[dieswaytoofast]

When Monorepos Go Bad – Mahesh Paolini-Subramanya – Medium

The PR from hell

Usually because #CowboyDeveloper decided to send in all 17 tickets as one single PR. But this time because, S**t Happens 

#Sigh