GifHub @jifhub - Tumblr Blog

Please do not try to sneak in this unrelated change.

When comments are directed to old code not relevant to your PR

This feels like something of a hack

While I can see the vast improvements that this change would make, I regret to inform you that we don't do it like that round here. Put it back.

I don't think i've done this right.

You appear to have got your conditional the wrong way round.

You're missing the point.

I appreciate the feedback... but the code stays exactly as it is.

No, seriously. I'm not changing it.

CI build has yet to complete.

This feature could benefit from the addition of KIF tests

I acknowledge that you made some comments, but I'm going to carry on regardless.

This doesn't do what you seem to think it does.

Rumber-stamping

Was this change fundamental to the pull request, or did Xcode just look at it sideways?

GifHub